Merged
Conversation
albertsola
requested review from
alephsur,
d3rky,
jentyk,
robcsegal,
ruben-sebrango and
svazquezco
as code owners
robcsegal
approved these changes
Aug 23, 2025
d3rky
requested changes
Aug 26, 2025
albertsola
changed the title
svazquezco
reviewed
Aug 26, 2025
svazquezco
reviewed
Aug 26, 2025
svazquezco
reviewed
Aug 26, 2025
svazquezco
reviewed
Aug 26, 2025
svazquezco
reviewed
Aug 26, 2025
albertsola
force-pushed
the
MPT-12359/async-base-resource-client
branch
from
a77013c to
ea71df4
Compare
svazquezco
reviewed
Aug 26, 2025
svazquezco
reviewed
Aug 26, 2025
svazquezco
reviewed
Aug 26, 2025
svazquezco
reviewed
Aug 26, 2025
svazquezco
reviewed
Aug 26, 2025
svazquezco
reviewed
Aug 26, 2025
svazquezco
requested changes
Aug 29, 2025
albertsola
force-pushed
the
MPT-12359/async-base-resource-client
branch
from
dfb13d0 to
bee0dfe
Compare
Contributor
|
Please, review the docstrings and typing. Also, the following comments I wrote before the last changes: It might be a good idea to split the generic files that include async and sync classes into async_xxx.py and sync_xxx.py class. |
albertsola
force-pushed
the
MPT-12359/async-base-resource-client
branch
4 times, most recently
from
fea6232 to
3d9b549
Compare
albertsola
force-pushed
the
MPT-12359/async-base-resource-client
branch
7 times, most recently
from
80ddf07 to
23c8fab
Compare
d3rky
approved these changes
Sep 1, 2025
d3rky
approved these changes
Sep 1, 2025
mpt_api_client/mpt_client.py
Outdated
| api_key: str | None = None, | ||
| http_client: HTTPClient | None = None, | ||
| ): | ||
| self.http_client = http_client or HTTPClient(base_url=base_url, api_token=api_key) |
Contributor
There was a problem hiding this comment.
What do you think about splitting the constructor into two parts:
- straight forward the only one
def __init__(
self,
base_url: str,
api_key: str,
):
self.http_client = HTTPClient(base_url=base_url, api_token=api_key)
@classmethod
def from_http_client(cls, http_client):
return cls(http_client.base_url, http_client.api_token)
or vice-versa, don't know what is better
Contributor
There was a problem hiding this comment.
depends on what is more used way to do it :-)
Contributor
Author
There was a problem hiding this comment.
I like the idea, but this breaks dependency injection.
What about:
def init(http_client):
def.http_client = http_client
def from_credentials(api_token, base_url=PROD_ENDPOINT):
return cls(HTTPClient(base_url, api_token)
albertsola
force-pushed
the
MPT-12359/async-base-resource-client
branch
5 times, most recently
from
c5bc557 to
5b20623
Compare
svazquezco
approved these changes
Sep 1, 2025
albertsola
force-pushed
the
MPT-12359/async-base-resource-client
branch
from
5b20623 to
1333fc6
Compare
- Unified ResourceClient and CollectionClient in Service - Renamed Resource Client to Service - Renamed Collection Client to Service - Renamed Resource to Model - Unified naming by adding Async as prefix to all Async implementation - Removed required custom collections in Services (CollectionClient) - Removed Resource Registry - Added Async Orders - Added Async MPT
albertsola
force-pushed
the
MPT-12359/async-base-resource-client
branch
from
1333fc6 to
c747af9
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.